-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX-#5702: Fix passing RangeIndex to loc. #5719
Merged
anmyachev
merged 7 commits into
modin-project:master
from
mvashishtha:5702-fix-range-index-in-loc
Mar 4, 2023
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5ffe5c9
FIX-#5702: Fix passing RangeIndex to loc.
0c8d268
Fix conversion from range labels to range positions
vnlitvinov ff07f29
Add test cases for loc with a range.
ee658d1
Fix slice_indexer stop by using 0 once it's missing.
77738d1
Fix test cases for index out of range.
55bbb7b
Update modin/core/storage_formats/base/query_compiler.py
mvashishtha 15be6d4
Revert "Update modin/core/storage_formats/base/query_compiler.py"
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this is the proper fix... I mean, this
if
should certainly be there as a fastpath solution! But...For me it feels like there's a bug somewhere else that this fastpath change just masks.
And I think I know where that is, just a few lines below! Note how
axis_labels.slice_indexer()
expects that its bothstart
andstop
arguments are labels which means that they signify closed interval, whileRangeIndex
/range
signify semi-open interval!