REFACTOR-#3865: remove troubleshooting section about using HDK with pyarrow.gandiva #6343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng HDK with pyarrow.gandiva Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
anmyachev
commented
Jul 3, 2023
| @@ -35,8 +35,6 @@ def noop_decorator(*args, **kwargs): | |||
| sys.modules["cudf"].DataFrame = type("DataFrame", (object,), {}) | |||
| if not hasattr(sys.modules["cupy"], "ndarray"): | |||
| sys.modules["cupy"].ndarray = type("ndarray", (object,), {}) | |||
| if not hasattr(sys.modules["pyhdk"], "PyDbEngine"): | |||
| sys.modules["pyhdk"].PyDbEngine = type("PyDbEngine", (object,), {}) | |||
There was a problem hiding this comment.
This is deprecated and is not used anywhere.
There was a problem hiding this comment.
My understanding that it was kept for backward compatibility, maybe @AndreyPavlenko knows more
There was a problem hiding this comment.
I think it could be safely removed.
|
The test below still passes, check it out. |
|
@YarShev this test works on ubuntu but fails on windows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sPyDBEnginefor OmniSci engine andpyarrow.gandivafor pyarrow storage format are incompatible #3865docs/development/architecture.rstis up-to-date