Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-#6968: Align API with pandas #6969

Merged
merged 3 commits into from
Feb 26, 2024
Merged

FIX-#6968: Align API with pandas #6969

merged 3 commits into from
Feb 26, 2024

Conversation

dchigarev
Copy link
Collaborator

@dchigarev dchigarev commented Feb 26, 2024 •
edited by YarShev
Loading

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Add skipna parameter to some groupby and resample methods #6968
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@dchigarev
FIX-modin-project#6968: Align API with pandas
4ed122b 
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
dchigarev
dchigarev commented Feb 26, 2024
View reviewed changes
environment-dev.yml Outdated Show resolved Hide resolved
@dchigarev dchigarev marked this pull request as ready for review February 26, 2024 15:25
@YarShev YarShev mentioned this pull request Feb 26, 2024
Merged
7 tasks
@dchigarev
remove defaulting to pandas
d7adfa2 
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
YarShev
YarShev reviewed Feb 26, 2024
View reviewed changes
modin/pandas/groupby.py Outdated Show resolved Hide resolved
@dchigarev
do not exclude pandas 2.2.0
e1bade5 
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
@YarShev YarShev merged commit a1d5dd4 into modin-project:master Feb 26, 2024
36 checks passed
anmyachev pushed a commit that referenced this pull request Jun 10, 2024
@dchigarev @anmyachev
FIX-#6968: Align API with pandas (#6969)
f3c07ad 
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-dpetersohn sfc-gh-dpetersohn sfc-gh-dpetersohn approved these changes

@YarShev YarShev YarShev approved these changes

@devin-petersohn devin-petersohn devin-petersohn approved these changes

@mvashishtha mvashishtha Awaiting requested review from mvashishtha mvashishtha is a code owner

@RehanSD RehanSD Awaiting requested review from RehanSD RehanSD is a code owner

@vnlitvinov vnlitvinov Awaiting requested review from vnlitvinov vnlitvinov is a code owner

@anmyachev anmyachev Awaiting requested review from anmyachev anmyachev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add skipna parameter to some groupby and resample methods
5 participants
@dchigarev @devin-petersohn @YarShev @anmyachev @sfc-gh-dpetersohn