TEST-#7066: Explicitly check for exceptions in test_io.py
#7067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
anmyachev
requested review from
devin-petersohn,
mvashishtha,
RehanSD,
YarShev,
vnlitvinov,
dchigarev and
a team
as code owners
YarShev
reviewed
Mar 12, 2024
modin/pandas/test/test_io.py
Outdated
| "parse_dates3" in request.node.callspec.id | ||
| or "parse_dates4" in request.node.callspec.id | ||
| ): | ||
| raising_exceptions = False |
There was a problem hiding this comment.
Should we put a similar FIXME here?
There was a problem hiding this comment.
I specified an exception
| from ray.exceptions import RayTaskError | ||
|
|
||
| # unwrap ray exceptions from remote worker | ||
| if isinstance(md_e, RayTaskError): |
There was a problem hiding this comment.
Do we have similar problems for Dask and Unidist?
There was a problem hiding this comment.
It seems not, otherwise they would have to break these tests too.
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
YarShev
reviewed
Mar 12, 2024
| @@ -380,9 +383,14 @@ def test_read_csv_parsing_1( | |||
| ).columns | |||
| } | |||
|
|
|||
| raising_exceptions = None | |||
| if engine == "c" and skipfooter != 0: | |||
There was a problem hiding this comment.
In all other cases there are no exceptions, right? or we just don't check raising exceptions in those cases?
There was a problem hiding this comment.
In all other cases there are no exceptions, right?
Yes and no. There really are no exceptions in these situations, but this is not being checked now, but it will be after #6954
7 tasks
YarShev
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -stest_io.py#7066docs/development/architecture.rstis up-to-date