Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT-#7102: Deprecate enable_api_only mode in modin logging #7114

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

arunjose696
Copy link
Collaborator

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Remove enable_api_only mode in modin logging #7102?
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

YarShev
YarShev previously approved these changes Mar 25, 2024
@YarShev
Copy link
Collaborator

YarShev commented Mar 25, 2024

@arunjose696, please rebase on current master to fix CI.

@arunjose696 arunjose696 changed the title FEAT-#7102: Remove enable_api_only mode in modin logging FEAT-#7102: Deprecate enable_api_only mode in modin logging Mar 25, 2024
@arunjose696
Copy link
Collaborator Author

@arunjose696, please rebase on current master to fix CI.

I have rebased on master, and have updated code just to add a deprecation message instead of removing the option.

Signed-off-by: Iaroslav Igoshev <iaroslav.igoshev@intel.com>
@YarShev YarShev merged commit 2b958e9 into modin-project:master Mar 25, 2024
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove enable_api_only mode in modin logging
3 participants