Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PERF-#7132: Preserve partition lengths in apply_full_axis with keep_partitioning=False #7133

Merged
merged 3 commits into from
Mar 28, 2024

Conversation

YarShev
Copy link
Collaborator

@YarShev YarShev commented Mar 27, 2024

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Preserve partition lengths in apply_full_axis with keep_partitioning=False #7132
  • tests passing
  • module layout described at docs/development/architecture.rst is up-to-date

@anmyachev
Copy link
Collaborator

@YarShev please rebase on master so that we can see identical blocks that will need to be moved a little.

…s with keep_partitioning=False

Signed-off-by: Iaroslav Igoshev <iaroslav.igoshev@intel.com>
Signed-off-by: Iaroslav Igoshev <iaroslav.igoshev@intel.com>
@YarShev YarShev force-pushed the dev/yigoshev-issue7132 branch 2 times, most recently from 948ddb0 to c7bfb24 Compare March 28, 2024 11:20
@YarShev
Copy link
Collaborator Author

YarShev commented Mar 28, 2024

@YarShev please rebase on master so that we can see identical blocks that will need to be moved a little.

@anmyachev, done

Co-authored-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
@anmyachev anmyachev merged commit 553eb5c into modin-project:master Mar 28, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preserve partition lengths in apply_full_axis with keep_partitioning=False
3 participants