FIX-#7102: Remove enable_api_only mode in modin logging #7194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: arunjose696 <arunjose696@gmail.com>
arunjose696
requested review from
devin-petersohn,
mvashishtha,
RehanSD,
YarShev,
vnlitvinov,
anmyachev,
dchigarev and
a team
as code owners
anmyachev
reviewed
Apr 17, 2024
| @@ -169,7 +169,7 @@ def configure_logging() -> None: | |||
| "modin.logger.default", | |||
| job_id, | |||
| "trace", | |||
| LogLevel.INFO if LogMode.get() == "enable_api_only" else LogLevel.DEBUG, | |||
There was a problem hiding this comment.
Are we losing the ability to configure the debug level?
There was a problem hiding this comment.
Yes the ability to configure would be lost, however the lower-level functionality would be made debug level (instead of info) in a further PR #7184
YarShev
approved these changes
Apr 17, 2024
|
@anmyachev, any other comments? |
anmyachev
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sdocs/development/architecture.rstis up-to-date