TEST-#7049: Add some sanity tests with pyarrow-backed pandas dataframes #7199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
…ndas dataframes Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
7 tasks
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
anmyachev
requested review from
devin-petersohn,
mvashishtha,
RehanSD,
YarShev,
vnlitvinov,
dchigarev and
a team
as code owners
Merged
7 tasks
anmyachev
commented
Apr 19, 2024
| pa = pytest.importorskip("pyarrow") | ||
|
|
||
| data = [[Decimal("3.19"), None], [None, Decimal("-1.23")]] | ||
| df_equals(*create_test_dfs(data, dtype=pd.ArrowDtype(pa.decimal128(3, scale=2)))) |
There was a problem hiding this comment.
df_equals function is used specifically since there is no benefit to using eval_general function (because the results of the constructors are tested).
YarShev
reviewed
Apr 22, 2024
| modin_series, pandas_series = create_test_series( | ||
| [-1.545, 0.211, None], dtype="float32[pyarrow]" | ||
| ) | ||
| df_equals(modin_series.mean(), pandas_series.mean()) |
There was a problem hiding this comment.
mean() returns a floating point number, so I don't see the need for it
Co-authored-by: Iaroslav Igoshev <Poolliver868@mail.ru>
YarShev
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Fixing problematic test cases will be part of the work on #7203.
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sdocs/development/architecture.rstis up-to-date