-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT-#6574: UserWarning no longer displayed when Series/DataFrames are small #7323
Conversation
…isplayed when Series and DataFrames are created under a certain size Signed-off-by: Jayson Willey <91502167+Jayson729@users.noreply.github.com>
Apparently this fails this test https://github.com/modin-project/modin/blob/main/modin/tests/pandas/test_series.py#L3430-L3439 because there is no longer a UserWarning being given in this case. I think changing this test to the following would solve this and still test the same thing, although we will have to def test_6782():
datetime_scalar = datetime.datetime(1970, 1, 1, 0, 0)
match = "Adding/subtracting object-dtype array to DatetimeArray not vectorized"
with warnings.catch_warnings():
warnings.filterwarnings("error", match, UserWarning)
pd.Series([datetime.datetime(2000, 1, 1)]) - datetime_scalar |
@Jayson729 yes, it looks great! Only the category should be different ( Note: It looks like |
Signed-off-by: Jayson Willey <91502167+Jayson729@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @Jayson729!
…DataFrames are small (modin-project#7323) Signed-off-by: Jayson Willey <91502167+Jayson729@users.noreply.github.com>
…DataFrames are small (modin-project#7323) Signed-off-by: Jayson Willey <91502167+Jayson729@users.noreply.github.com>
What do these changes do?
When creating a DataFrame or Series, no longer display
UserWarning: Distributing <class 'NoneType'> object. This may take some time.
when the size of the DataFrame or Series is small.flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
git commit -s
docs/development/architecture.rst
is up-to-date