Add support for level argument in any, all #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for level in: *Any *All *Refactored count *Added tests for Any and All
Codecov Report
@@ Coverage Diff @@
## master #833 +/- ##
==========================================
+ Coverage 90.72% 90.72% +<.01%
==========================================
Files 47 47
Lines 5658 5672 +14
==========================================
+ Hits 5133 5146 +13
- Misses 525 526 +1
Continue to review full report at Codecov.
|
devin-petersohn
requested changes
Oct 16, 2019
Updated functions to add keyword arguments to `_handle_level_agg`
Reformatting and adding skipna to calls to `handle_level_agg` in `all` and `any`
|
@rliu4439 I do not have the privileges to add these. Can you add these suggested changes? You can do it in the browser. |
Update to check for `numeric_only` and not pass into _handle_level_agg
devin-petersohn
approved these changes
Oct 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Refactored code supporting the
levelargument incount.Added support for the
levelargument for:anyallRelated issue number
flake8 modinblack --check modin