Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where certain arguments were not defaulting to pandas #890

Merged
merged 2 commits into from
Dec 9, 2019

Conversation

devin-petersohn
Copy link
Collaborator

What do these changes do?

Related issue number

  • passes flake8 modin
  • passes black --check modin
  • tests added and passing

* Resolves modin-project#876
* Convert all DataFrame and Series arguments to pandas when doing a
  pandas default implementation
* Add tests
@codecov
Copy link

codecov bot commented Dec 4, 2019

Codecov Report

Merging #890 into master will decrease coverage by 0.93%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #890      +/-   ##
==========================================
- Coverage   88.62%   87.68%   -0.94%     
==========================================
  Files          54       54              
  Lines        5740     5727      -13     
==========================================
- Hits         5087     5022      -65     
- Misses        653      705      +52
Impacted Files Coverage Δ
modin/pandas/base.py 94.94% <100%> (+0.03%) ⬆️
modin/backends/pandas/parsers.py 61.9% <0%> (-33.34%) ⬇️
modin/engines/base/frame/axis_partition.py 33.33% <0%> (-26.67%) ⬇️
modin/data_management/utils.py 56.25% <0%> (-21.88%) ⬇️
modin/engines/ray/generic/io.py 91.3% <0%> (-1.64%) ⬇️
modin/engines/base/frame/data.py 91.34% <0%> (-1.21%) ⬇️
modin/engines/ray/pandas_on_ray/frame/partition.py 89.41% <0%> (-1.18%) ⬇️
modin/backends/pandas/query_compiler.py 81.79% <0%> (-0.68%) ⬇️
modin/pandas/series.py 93.74% <0%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c34c22...6640def. Read the comment docs.

@devin-petersohn devin-petersohn merged commit 4167efe into modin-project:master Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

df.assign() not working with index mismatches
1 participant