Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure import attempt to only try Ray if on a non-windows machine #945

Merged
merged 2 commits into from
Jan 2, 2020

Conversation

devin-petersohn
Copy link
Collaborator

What do these changes do?

Related issue number

  • passes flake8 modin
  • passes black --check modin
  • [x] tests added and passing

@codecov
Copy link

codecov bot commented Jan 2, 2020

Codecov Report

Merging #945 into master will decrease coverage by 0.01%.
The diff coverage is 35.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #945      +/-   ##
==========================================
- Coverage   87.67%   87.66%   -0.02%     
==========================================
  Files          54       54              
  Lines        5728     5730       +2     
==========================================
+ Hits         5022     5023       +1     
- Misses        706      707       +1
Impacted Files Coverage Δ
modin/__init__.py 68.75% <35.71%> (-1.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0586b0...deba701. Read the comment docs.

@devin-petersohn devin-petersohn merged commit 308fd52 into modin-project:master Jan 2, 2020
@devin-petersohn devin-petersohn added this to the 0.6.4 milestone Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip ray import for Winows and avoid ModuleNotFoundError
1 participant