[ext] Check for device.hpp before including in CMSIS-DSP #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add an example for Linux using CMSIS-DSP? Otherwise future refactoring will break this again. |
|
Okay so after trying to add an example for this, I realized that the CMSIS DSP module isn't even available when using |
|
Any update on this? I still find this a valuable idea! |
|
I've been busy with classes lately, so I haven't had a chance to dig through our project to find what was causing this issue yet :( If you want this to be added anyway, we would also have to also allow the DSP module to be used in hosted environments. Removing the check for that shouldn't be hard, but idk if it would simply work or require more effort? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks for the existence of
modm/platform/device.hppbefore including it inarm_math.h. This fixes CMSIS-DSP not compiling when running on a hosted platform (#1201).