This repository has been archived by the owner on Aug 3, 2024. It is now read-only.
Fix building for Cloudflare Nitro preset #1726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that Rollup node-resolve module doesn't properly deal with trailing slashes, causing it to thing that `string_decoder` is a built-in Node.js dependency and attempt to import it from `unenv`, which will obviously fail, because `string_decoder` is not, in fact, a Node.js dependency, but an individual dependency of `readable-stream`. This adds a small patch for `readable-stream@2.3.8` dependency, which removes the leading slash, which seems to fix the builds. This probably should be reported to relevant developers (Rollup node-resolve plugin or Nitro?).
brawaru
force-pushed
the
fix/cloudflare-builds
branch
from
c1b495d
to
7b788ff
Compare
Geometrically
approved these changes
Jun 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that Rollup node-resolve module doesn't properly deal with trailing slashes, causing it to think that
string_decoderis a built-in Node.js dependency and attempt to import it fromunenv, which will obviously fail, becausestring_decoderis not, in fact, a Node.js dependency, but an individual dependency ofreadable-stream.This adds a small patch for
readable-stream@2.3.8dependency, which removes the leading slash, which seems to fix the builds.This probably should be reported to relevant developers (Rollup node-resolve plugin or Nitro?).