Skip to content
This repository has been archived by the owner on Aug 3, 2024. It is now read-only.

Fix page crash on orgs #1727

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Fix page crash on orgs #1727

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pages/[type]/[id].vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1264,7 +1264,8 @@ const members = computed(() => {
)
: x.is_owner
)
const rest = acceptedMembers.filter((x) => x.user.id !== owner.user.id) || []

const rest = acceptedMembers.filter((x) => !owner || x.user.id !== owner.user.id) || []
Copy link
Contributor

@brawaru brawaru Jun 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would've been better to just skip filtering altogether if owner is falsey :p

Suggested change
const rest = acceptedMembers.filter((x) => !owner || x.user.id !== owner.user.id) || []
const rest = owner ? acceptedMembers.filter((x) => x.user.id !== owner.user.id) : acceptedMembers

Also that || [] seems redundant since filter never returns undefined.


rest.sort((a, b) => {
if (a.role === b.role) {
Expand Down
Loading