Merge branch '49-fix-case-indetification-in-linear-transformation-rev…

…ert' into 'main' Resolve "fix case indetification in linear transformation revert" Closes #49 See merge request IBG-1/ModSim/hops!56
modsim · Jan 21, 2024 · f1d4a35 · f1d4a35
2 parents 4d7c108 + 6a6468c
commit f1d4a35
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/hops/Transformation/LinearTransformation.hpp b/src/hops/Transformation/LinearTransformation.hpp
@@ -31,9 +31,9 @@ namespace hops {
         }
 
         VectorType revert(const VectorType &vector) const override {
-            if (matrix.isLowerTriangular()) {
+            if (matrix.cols() == matrix.rows() && matrix.isLowerTriangular()) {
                 return matrix.template triangularView<Eigen::Lower>().solve(vector - shift);
-            } else if (matrix.isUpperTriangular()) {
+            } else if (matrix.cols() == matrix.rows() && matrix.isUpperTriangular()) {
                 return matrix.template triangularView<Eigen::Upper>().solve(vector - shift);
             } else {
                 VectorType rhs = vector-shift;