Tags update on Instance

lib/ansible/module_utils/gcp_utils.py

@@ -19,6 +19,7 @@
 from ansible.module_utils.basic import AnsibleModule, env_fallback
 from ansible.module_utils.six import string_types
 from ansible.module_utils._text import to_text
+import ast
 import os
 
 
@@ -60,8 +61,15 @@ def replace_resource_dict(item, value):
     else:
         if not item:
             return item
-        return item.get(value)
+        if isinstance(item, dict):
+            return item.get(value)
 
+        # Item could be a string or a string representing a dictionary.
+        try:
+            new_item = ast.literal_eval(item)
+            return replace_resource_dict(new_item, value)
+        except ValueError:
+            return new_item
 
 # Handles all authentation and HTTP sessions for GCP API calls.
 class GcpSession(object):
@@ -77,12 +85,19 @@ def get(self, url, body=None, **kwargs):
         except getattr(requests.exceptions, 'RequestException') as inst:
             self.module.fail_json(msg=inst.message)
 
-    def post(self, url, body=None):
+    def post(self, url, body=None, headers={}, **kwargs):
+        kwargs.update({'json': body, 'headers': self._merge_dictionaries(headers, self._headers())})
         try:
             return self.session().post(url, json=body, headers=self._headers())
         except getattr(requests.exceptions, 'RequestException') as inst:
             self.module.fail_json(msg=inst.message)
 
+    def post_contents(self, url, file_contents=None, headers={}, **kwargs):
+        try:
+            return self.session().post(url, data=file_contents, headers=self._headers())
+        except getattr(requests.exceptions, 'RequestException') as inst:
+            self.module.fail_json(msg=inst.message)
+
     def delete(self, url, body=None):
         try:
             return self.session().delete(url, json=body, headers=self._headers())
@@ -104,7 +119,7 @@ def patch(self, url, body=None, **kwargs):
 
     def session(self):
         return AuthorizedSession(
-            self._credentials().with_scopes(self.module.params['scopes']))
+            self._credentials())
 
     def _validate(self):
         if not HAS_REQUESTS:
@@ -126,11 +141,11 @@ def _validate(self):
     def _credentials(self):
         cred_type = self.module.params['auth_kind']
         if cred_type == 'application':
-            credentials, project_id = google.auth.default()
+            credentials, project_id = google.auth.default(scopes=self.module.params['scopes'])
             return credentials
         elif cred_type == 'serviceaccount':
             path = os.path.realpath(os.path.expanduser(self.module.params['service_account_file']))
-            return service_account.Credentials.from_service_account_file(path)
+            return service_account.Credentials.from_service_account_file(path).with_scopes(self.module.params['scopes'])
         elif cred_type == 'machineaccount':
             return google.auth.compute_engine.Credentials(
                 self.module.params['service_account_email'])
@@ -142,6 +157,11 @@ def _headers(self):
             'User-Agent': "Google-Ansible-MM-{0}".format(self.product)
         }
 
+    def _merge_dictionaries(self, a, b):
+        new = a.copy()
+        new.update(b)
+        return new
+
 
 class GcpModule(AnsibleModule):
     def __init__(self, *args, **kwargs):
@@ -152,7 +172,10 @@ def __init__(self, *args, **kwargs):
         kwargs['argument_spec'] = self._merge_dictionaries(
             arg_spec,
             dict(
-                project=dict(required=True, type='str'),
+                project=dict(
+                    required=False,
+                    type='str',
+                    fallback=(env_fallback, ['GCP_PROJECT'])),
                 auth_kind=dict(
                     required=False,
                     fallback=(env_fallback, ['GCP_AUTH_KIND']),