Merge pull request GoogleCloudPlatform#176 from modular-magician/code…

…gen-pr-991 Accommodate the new iamcredentials service in tests
modular-magician · Dec 5, 2018 · cc7e0b6 · cc7e0b6
2 parents 73760a6 + a798c62
commit cc7e0b6
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 5 deletions.
diff --git a/google-beta/resource_google_project_services_test.go b/google-beta/resource_google_project_services_test.go
@@ -19,9 +19,9 @@ func TestAccProjectServices_basic(t *testing.T) {
 
 	org := getTestOrgFromEnv(t)
 	pid := "terraform-" + acctest.RandString(10)
-	services1 := []string{"iam.googleapis.com", "cloudresourcemanager.googleapis.com"}
+	services1 := []string{"cloudbuild.googleapis.com", "cloudresourcemanager.googleapis.com"}
 	services2 := []string{"cloudresourcemanager.googleapis.com"}
-	oobService := "iam.googleapis.com"
+	oobService := "cloudbuild.googleapis.com"
 	resource.Test(t, resource.TestCase{
 		PreCheck:  func() { testAccPreCheck(t) },
 		Providers: testAccProviders,
@@ -70,7 +70,7 @@ func TestAccProjectServices_authoritative(t *testing.T) {
 	org := getTestOrgFromEnv(t)
 	pid := "terraform-" + acctest.RandString(10)
 	services := []string{"cloudresourcemanager.googleapis.com"}
-	oobService := "iam.googleapis.com"
+	oobService := "cloudbuild.googleapis.com"
 	resource.Test(t, resource.TestCase{
 		PreCheck:  func() { testAccPreCheck(t) },
 		Providers: testAccProviders,
@@ -106,8 +106,8 @@ func TestAccProjectServices_authoritative2(t *testing.T) {
 
 	org := getTestOrgFromEnv(t)
 	pid := "terraform-" + acctest.RandString(10)
-	oobServices := []string{"iam.googleapis.com", "cloudresourcemanager.googleapis.com"}
-	services := []string{"iam.googleapis.com"}
+	oobServices := []string{"cloudbuild.googleapis.com", "cloudresourcemanager.googleapis.com"}
+	services := []string{"cloudbuild.googleapis.com"}
 
 	resource.Test(t, resource.TestCase{
 		PreCheck:  func() { testAccPreCheck(t) },
@@ -217,6 +217,7 @@ func TestAccProjectServices_pagination(t *testing.T) {
 		"firestore.googleapis.com",
 		"genomics.googleapis.com",
 		"iam.googleapis.com",
+		"iamcredentials.googleapis.com",
 		"language.googleapis.com",
 		"logging.googleapis.com",
 		"ml.googleapis.com",

diff --git a/google-beta/resource_kms_crypto_key_iam_test.go b/google-beta/resource_kms_crypto_key_iam_test.go
@@ -187,6 +187,7 @@ resource "google_project_services" "test_project" {
   services = [
      "cloudkms.googleapis.com",
      "iam.googleapis.com",
+     "iamcredentials.googleapis.com",
   ]
 }
 
@@ -230,6 +231,7 @@ resource "google_project_services" "test_project" {
   services = [
      "cloudkms.googleapis.com",
      "iam.googleapis.com",
+     "iamcredentials.googleapis.com",
   ]
 }
 
@@ -282,6 +284,7 @@ resource "google_project_services" "test_project" {
   services = [
      "cloudkms.googleapis.com",
      "iam.googleapis.com",
+     "iamcredentials.googleapis.com",
   ]
 }
 

diff --git a/google-beta/resource_kms_key_ring_iam_test.go b/google-beta/resource_kms_key_ring_iam_test.go
@@ -179,6 +179,7 @@ resource "google_project_services" "test_project" {
   services = [
      "cloudkms.googleapis.com",
      "iam.googleapis.com",
+     "iamcredentials.googleapis.com",
   ]
 }
 
@@ -217,6 +218,7 @@ resource "google_project_services" "test_project" {
   services = [
      "cloudkms.googleapis.com",
      "iam.googleapis.com",
+     "iamcredentials.googleapis.com",
   ]
 }
 
@@ -264,6 +266,7 @@ resource "google_project_services" "test_project" {
   services = [
      "cloudkms.googleapis.com",
      "iam.googleapis.com",
+     "iamcredentials.googleapis.com",
   ]
 }
 
@@ -302,6 +305,7 @@ resource "google_project_services" "test_project" {
   services = [
      "cloudkms.googleapis.com",
      "iam.googleapis.com",
+     "iamcredentials.googleapis.com",
   ]
 }