display_name not in response (hashicorp#6867) (hashicorp#4925)

* display_name not in response * use ignore_read instead Co-authored-by: Edward Sun <sunedward@google.com> Signed-off-by: Modular Magician <magic-modules@google.com> Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Edward Sun <sunedward@google.com>
modular-magician · Nov 29, 2022 · 04ec1a6 · 04ec1a6
1 parent ae4d0f8
commit 04ec1a6
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 8 deletions.
diff --git a/.changelog/6867.txt b/.changelog/6867.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+alloydb: fixed permdiff on `display_name` of `google_alloydb_instance`
+```
diff --git a/google-beta/resource_alloydb_instance.go b/google-beta/resource_alloydb_instance.go
@@ -320,9 +320,6 @@ func resourceAlloydbInstanceRead(d *schema.ResourceData, meta interface{}) error
 	if err := d.Set("state", flattenAlloydbInstanceState(res["state"], d, config)); err != nil {
 		return fmt.Errorf("Error reading Instance: %s", err)
 	}
-	if err := d.Set("display_name", flattenAlloydbInstanceDisplayName(res["displayName"], d, config)); err != nil {
-		return fmt.Errorf("Error reading Instance: %s", err)
-	}
 	if err := d.Set("gce_zone", flattenAlloydbInstanceGceZone(res["gceZone"], d, config)); err != nil {
 		return fmt.Errorf("Error reading Instance: %s", err)
 	}
@@ -569,10 +566,6 @@ func flattenAlloydbInstanceState(v interface{}, d *schema.ResourceData, config *
 	return v
 }
 
-func flattenAlloydbInstanceDisplayName(v interface{}, d *schema.ResourceData, config *Config) interface{} {
-	return v
-}
-
 func flattenAlloydbInstanceGceZone(v interface{}, d *schema.ResourceData, config *Config) interface{} {
 	return v
 }

diff --git a/google-beta/resource_alloydb_instance_generated_test.go b/google-beta/resource_alloydb_instance_generated_test.go
@@ -42,7 +42,7 @@ func TestAccAlloydbInstance_alloydbInstanceBasicExample(t *testing.T) {
 				ResourceName:            "google_alloydb_instance.default",
 				ImportState:             true,
 				ImportStateVerify:       true,
-				ImportStateVerifyIgnore: []string{"cluster", "instance_id", "reconciling", "update_time"},
+				ImportStateVerifyIgnore: []string{"display_name", "cluster", "instance_id", "reconciling", "update_time"},
 			},
 		},
 	})