Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to land PRs with UNSTABLE merge status #55

Closed
rvi opened this issue Dec 10, 2024 · 3 comments · Fixed by #60
Closed

Allow to land PRs with UNSTABLE merge status #55

rvi opened this issue Dec 10, 2024 · 3 comments · Fixed by #60
Labels
enhancement New feature or request

Comments

@rvi
Copy link

rvi commented Dec 10, 2024

Hi,
Thanks for the great tool, I've been using it for a day and I love it so far!

One thing that doesn't work well for me is I can't land a PR with an UNSTABLE merge status. Could we allow this? Maybe by passing a flag in argument?
@ZolotukhinM
Copy link
Collaborator

ZolotukhinM commented Dec 10, 2024 •
edited
Loading

Are you talking about UNKNOWN? If so, then it's been fixed in #49 - we just haven't had a new release since that fix came in.

@rvi
Copy link
Author

rvi commented Dec 10, 2024

No I'm talking about UNSTABLE this happens when some checks are failing but they are optional checks. It would be great to allow to land in this case, something like: stack-pr land --allow-unstable

@AmaranthineCodices AmaranthineCodices added the enhancement New feature or request label Dec 11, 2024
TheCoreMan added a commit to TheCoreMan/stack-pr that referenced this issue Jan 16, 2025
@TheCoreMan
Fixes modular#55: add support for unstable merge status
ac0b37d 
Sometimes you have broken actions that are not because of you. My
example is Vercel 😠 failing my PR just because I don't have
a user in some repo.

Anyways, here's a fix - added a commandline switch with the merge
mode. The default is "Clean" which is what you had before, so people
who already use the tool won't feel the difference.

Signed-off-by: Shay Nehmad <dude500@gmail.com>
@TheCoreMan TheCoreMan mentioned this issue Jan 16, 2025
Closed
@TheCoreMan
Copy link
Contributor

Hey @ZolotukhinM , I opened a PR which adds this functionality

CC: @rvi feel free to use the tool from my fork for now, just clone and pipx install . --force.

@ZolotukhinM ZolotukhinM mentioned this issue Feb 5, 2025
Merged
ZolotukhinM added a commit that referenced this issue Feb 5, 2025
@ZolotukhinM
Allow merging PRs with 'UNSTABLE' status on GH.
efc1d22 
Fixes #55.

Co-authored-by: Shay Nehmad <dude500@gmail.com>

stack-info: PR: #60, branch: ZolotukhinM/stack/2
ZolotukhinM added a commit that referenced this issue Feb 5, 2025
@ZolotukhinM @TheCoreMan
Allow merging PRs with 'UNSTABLE' status on GH. (#60)
0917aa8 
Fixes #55.

Co-authored-by: Shay Nehmad <dude500@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow merging PRs with 'UNSTABLE' status on GH. modular/stack-pr
4 participants
@rvi @ZolotukhinM @TheCoreMan @AmaranthineCodices