[stdlib] Add SSO to String by using SBO in List with materialization workaround #2827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
gabrieldemarmiesse
changed the title
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
gabrieldemarmiesse
force-pushed
the
add_sso_to_string
branch
from
6663fd2
to
e2a1575
Compare
gabrieldemarmiesse
changed the title
gabrieldemarmiesse
force-pushed
the
add_sso_to_string
branch
from
8feea1c
to
22ba7d1
Compare
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
This was referenced May 26, 2024
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
… remove_copyable_from_collectionelement Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
…lectionelementnew
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
|
@gabrieldemarmiesse have you given this a rebase lately to see how things are looking? |
|
Not really. I can rebase if you want |
If you have some time, rebasing the SSO PRs to see where they're at with regard to compiler bugs would be very valuable. We're unwinding the explicit copyability work ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves part of #2467
This PR is part of three PRs to read and merge in the following order
List, take 2 #2825The interesting part is the diff between this PR and the PR #2826
You can find this diff here: gabrieldemarmiesse/mojo@fix_materializing...gabrieldemarmiesse:mojo:add_sso_to_string
As you can see it's quite small.
A few update on the benchmarks, I removed the slowest previous implementations of SSO:
Listdirectly (f27b43a) from the 11/05/2024Listdirectly (916c64b) from the 26/05/2024 with the materialization workaroundString(in bytes)What is inside?
This is the final touch and by far the simplest PR. We add a small buffer of size 15 to the
Listused internally byString. That's it. No other changes needed. Why 15? Well 16 was the best number according to my benchmarks but we have one more byte as the workaround flag inListnow (see the previous PR) and we'd like to have aStringthat has a size being a multiple of 8 for the cache lines and padding.When the bug is fixed, the flag will be removed and we'll be free to use 16 as the buffer size or any other multiple of 8.