Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: support customized branch names for created PRs #18

Closed
PeimingLiu opened this issue Aug 21, 2024 · 3 comments · Fixed by #33
Closed

Feature request: support customized branch names for created PRs #18

PeimingLiu opened this issue Aug 21, 2024 · 3 comments · Fixed by #33

Comments

@PeimingLiu
Copy link

PeimingLiu commented Aug 21, 2024

Hi,

Seems that stack-pr hardcoded to use "f{username}/stack/{id}" for the branch name, but some repos have restriction on the branch name (e.g., LLVM). I tried to use the tool but could only get it work by modifying the code myself.

@ZolotukhinM
Copy link
Collaborator

That sounds like a reasonable feature to have - given that you've already made the changes, would you be able to send a pull request to add this? :)

@PeimingLiu
Copy link
Author

Guess what, I just hardcoded a different prefix to fit my need too :).

With that being said, I also don't think simply requiring a --prefix argument to override the default behavior is ideal either. Maybe it would be better to support a per-project configuration?

@ZolotukhinM
Copy link
Collaborator

Yeah, we can have something like a branch-name template. E.g. by default it would be <<USERNAME>>/stack/<<ID>> (syntax is arbitrary), but then it can be configured to be something else, e.g. users/<<USERNAME>>/stack/<<ID>>.

@ZolotukhinM ZolotukhinM changed the title Support Customized Branch Prefix? Feature request: support customized branch names for created PRs Aug 24, 2024
ZolotukhinM added a commit that referenced this issue Oct 6, 2024
Closes #18.

stack-info: PR: #33, branch: ZolotukhinM/stack/3
ZolotukhinM added a commit that referenced this issue Oct 6, 2024
Closes #18.

stack-info: PR: #33, branch: ZolotukhinM/stack/3
ZolotukhinM added a commit that referenced this issue Oct 6, 2024
Closes #18.

stack-info: PR: #33, branch: ZolotukhinM/stack/3
ZolotukhinM added a commit that referenced this issue Oct 6, 2024
Closes #18.

stack-info: PR: #33, branch: ZolotukhinM/stack/3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants