Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storybook-addon): use new api to get the storybook virtual static modules #3298

Conversation

fyodorovandrei
Copy link
Contributor

@fyodorovandrei fyodorovandrei commented Dec 1, 2024

Description

  1. Since I opened some PRs(webpack-virtual-modules and storybook) to enable the possibility of accessing the Storybook virtual modules, I finally applied the new method.
  2. Now the util normalizeStories is imported from @storybook/core and not more from deprecated @storybook/core-common

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

Copy link

changeset-bot bot commented Dec 1, 2024

🦋 Changeset detected

Latest commit: 0197c22

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@module-federation/storybook-addon Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Dec 1, 2024

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit 0197c22
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/6774903e415fe60008e3ce45
😎 Deploy Preview https://deploy-preview-3298--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ScriptedAlchemy
Copy link
Member

Lock file outdated

… upgrade-package-deps-to-allow-to-use-new-api

# Conflicts:
#	packages/storybook-addon/package.json
…-use-new-api' into upgrade-package-deps-to-allow-to-use-new-api

# Conflicts:
#	packages/storybook-addon/package.json
@fyodorovandrei
Copy link
Contributor Author

@ScriptedAlchemy done ✅

… upgrade-package-deps-to-allow-to-use-new-api

# Conflicts:
#	packages/storybook-addon/package.json
@fyodorovandrei
Copy link
Contributor Author

I hope this will be the last conflict merge from the main branch for this year 🤣

…allow-to-use-new-api

# Conflicts:
#	packages/storybook-addon/package.json
@ScriptedAlchemy ScriptedAlchemy merged commit 3f9677d into module-federation:main Jan 1, 2025
4 checks passed
@fyodorovandrei fyodorovandrei deleted the upgrade-package-deps-to-allow-to-use-new-api branch January 1, 2025 13:49
@KyrieLii KyrieLii mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants