Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: CRA exemple without CRACO #2028

Merged
merged 1 commit into from
Jun 21, 2022
Merged

refactor: CRA exemple without CRACO #2028

merged 1 commit into from
Jun 21, 2022

Conversation

neysimoes
Copy link
Contributor

@neysimoes neysimoes commented Jun 10, 2022 •
edited
Loading

CRACO don't support CRA 5 yet and searching for maintainers.

However, CRA still does not have a way of working with Module Federation.

This solution:

  • Does not require any external dependency on the CRA
  • Does not need to be ejected
  • Small code implementation

Source:
https://github.com/luigidomingues/extend-cra-config

This PR resolve this issues:

@CLAassistant
Copy link

CLAassistant commented Jun 10, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

This was referenced Jun 15, 2022
Closed
Closed
@ScriptedAlchemy ScriptedAlchemy merged commit 9239949 into module-federation:master Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franklinjavier franklinjavier franklinjavier approved these changes

@wellingtonnascimento wellingtonnascimento wellingtonnascimento approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@neysimoes @CLAassistant @franklinjavier @wellingtonnascimento @ScriptedAlchemy