Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix user messages GetList processor #16635

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

halftrainedharry
Copy link
Contributor

What does it do?

Fixes the join condition in the processor query.

Why is it needed?

The result is incorrect, if in the user profile the id is different from the internalKey.

How to test

Make sure that on your installation, the (auto-increment) ID column of the modUserProfile is out-of-sync with the modUser ID.
Test that all messages are visible and the values of username and fullname (in the columns "Sender" and "Recipient") correspond to each other.

Related issue(s)/PR(s)

Resolves #16634 for MODX 3.x

@opengeek opengeek changed the title [3.x] Fix user messages GetList processor Fix user messages GetList processor Oct 21, 2024
@opengeek opengeek merged commit 686bf2f into modxcms:3.x Oct 21, 2024
5 checks passed
jenswittmann pushed a commit to jenswittmann/revolution that referenced this pull request Dec 23, 2024
### What does it do?
Fixes the join condition in the processor query.

### Why is it needed?
The result is incorrect, if in the user profile the `id` is different
from the `internalKey`.

### How to test
Make sure that on your installation, the (auto-increment) ID column of
the `modUserProfile` is out-of-sync with the `modUser` ID.
Test that all messages are visible and the values of `username` and
`fullname` (in the columns "Sender" and "Recipient") correspond to each
other.

### Related issue(s)/PR(s)
Resolves modxcms#16634 for MODX 3.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect list of messages in the "Messages" (user-menu)
2 participants