Longer fid

[hrchu]

No description provided.

[hrchu]

Note that I do not use unsigned long since Long.parseUnsignedLong() is only available in Java 8.

ps. the issue break my production site about twelve hours :(

[hrchu]

Of cause it pass unit test and integration test.

[hrchu]

@massdosage @jyukutyo could you review and merge this if think the code is ok? Thanks

[jyukutyo]

Sorry for late. I reviewed code and it is OK!

[hrchu]

Thanks @jyukutyo, could you also review #23 #24 when you have time?

[massdosage]

Sorry for the long delay, I've been really busy and then away on holiday but I'm back now. This PR looks fine but makes me wonder why we modelled it as a number in the first place, possibly this was based on the previous Java client. What is the type of fid in the underlying MogileFS database? (I don't have it all setup on the machine I'm currently on)

[hrchu]

It is AUTO_INCREMENT INT in mogilefs tracker db (It may differ if you use other RDBMS except mysql)

[massdosage]

Hmm, a MySQL INT should map just fine to a Java int type (see http://dev.mysql.com/doc/refman/5.7/en/integer-types.html) unless there is some way you can say it's unsigned in which case it would need to be a long. I assume you've actually run into this issue in production so it can happen?

[hrchu]

@massdosage oh sorry for the wrong info, It is actually bigint(20) unsigned since mogilefs 2.32

[massdosage]

OK, a long makes sense then. I'll merge.