Cache abstraction layer with Redis support #19
Conversation
|
And yes, I did read memcache-support.txt :p For Redis, device IDs are stored using sets (SADD, SMEMBERS). Socket addresses are supported (e.g. /tmp/redis.sock). I pretty much followed the structure of Mgd::get_store. |
|
Thanks a lot for doing this. I'm still trying to get enough round-tuits to properly review, but you've fixed a few good things so far. Not sure if it'll make 2.65, but if not, 2.66 for sure! |
| $cache_ttl = MogileFS::Config->server_setting_cached('memcache_ttl') || 3600; | ||
| } else { | ||
| $servers = MogileFS->config('cache_servers'); | ||
| $type = MogileFS->config('cache_type'); |
There was a problem hiding this comment.
It seems like it'd be more helpful to either default to something here or print a warning that cache_type must be specified with cache_servers.
|
Hi again! I'm a terrible person: Are you around to help deal with a few more comments on the patch series so we can toss it in? Thanks! |
|
Sorry about that, I'll try to get to it in these couple of days. |
|
awesome, thanks! Though all apologies are mine! |
|
ping again! If it's fixed up within the next week it could go out in the next cut |
Changes MogileFS::Config->memcache_client to Mgd::get_cache. Cache options are now configured in mogilefsd.conf (cache_type, cache_servers and cache_ttl). Preserves functionality of the previous cache implementation (using server_settings). Adapters supplied for Memcache and Redis.