Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete covariance from transformers #327

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

urmaul
Copy link

@urmaul urmaul commented May 3, 2024

Has the version number been increased?

  • Yes! (or not but it was intended to not increase it)

@urmaul urmaul changed the title Delete covariance from Writer Delete covariance from transformers May 8, 2024
implicit object DurationReader extends Reader[PBDuration, Duration] {
def read(protobuf: PBDuration): PbResult[FiniteDuration] =
PbSuccess((Duration(protobuf.seconds, SECONDS) + Duration(protobuf.nanos.toLong, NANOSECONDS)).toCoarsest)
}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copypasted from FiniteDurationReader because we need a separate reader now.

@urmaul urmaul marked this pull request as ready for review May 8, 2024 15:24
@houcros houcros removed their request for review June 20, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant