Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quickinstall #688

Merged
merged 5 commits into from
Sep 23, 2018
Merged

Quickinstall #688

merged 5 commits into from
Sep 23, 2018

Conversation

RogerHaase
Copy link
Member

No description provided.

args += [
'--process-dependency-links',
]
args += ['--process-dependency-links', ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this at all? iirc i removed all the hg/git repo links from setup.py.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before change, when I run "m quickinstall" to upgrade packages, the output says:

Requirement not upgraded as not directly required: blinker>=1.1 in c:\git\moin-venv-python\lib\site-packages (from moin==2.0.0.dev150+g79b2b467.d20180922) (1.4)
Requirement not upgraded as not directly required: docutils>=0.8.1 in c:\git\moin-venv-python\lib\site-packages (from moin==2.0.0.dev150+g79b2b467.d20180922) (0.14)

After change, the output says:

Requirement already up-to-date: blinker>=1.1 in c:\git\moin-venv-python\lib\site-packages (from moin==2.0.0.dev150+g79b2b467.d20180922) (1.4)
Requirement already up-to-date: docutils>=0.8.1 in c:\git\moin-venv-python\lib\site-packages (from moin==2.0.0.dev150+g79b2b467.d20180922) (0.14)

Testing same change on my old bitbucket repo that has not been updated in a while, before change:

Requirement not upgraded as not directly required: Markdown>=2.1.1 in c:\bitbucket\moin2-venv-python\lib\site-packages (from moin==2.0.0a0) (2.6.11)

After change:

Collecting Markdown>=2.1.1 (from moin==2.0.0a0)
  Using cached https://files.pythonhosted.org/packages/7a/fd/e22357c299e93c0bc11ec8ba54e79f98dd568e09adfe9b39d6852c744938/Markdown-3.0-py2.py3-none-any.whl
snip...
Installing collected packages: Markdown, imagesize, typing, setuptools, sphinx, XStatic, XStatic-jQuery, XStatic-Pygments, moin, py, certifi, pyparsing
  Found existing installation: Markdown 2.6.11
    Uninstalling Markdown-2.6.11:
      Successfully uninstalled Markdown-2.6.11
  Found existing installation: imagesize 1.0.0
    Uninstalling imagesize-1.0.0:
      Successfully uninstalled imagesize-1.0.0
  Found existing installation: typing 3.6.4
    Uninstalling typing-3.6.4:
      Successfully uninstalled typing-3.6.4
  Found existing installation: setuptools 40.2.0
    Uninstalling setuptools-40.2.0:
      Successfully uninstalled setuptools-40.2.0
  Found existing installation: Sphinx 1.7.7
    Uninstalling Sphinx-1.7.7:
      Successfully uninstalled Sphinx-1.7.7
  Found existing installation: XStatic 1.0.1
    Uninstalling XStatic-1.0.1:
      Successfully uninstalled XStatic-1.0.1
  Found existing installation: XStatic-jQuery 1.10.2.1
    Uninstalling XStatic-jQuery-1.10.2.1:
      Successfully uninstalled XStatic-jQuery-1.10.2.1
  Found existing installation: XStatic-Pygments 1.6.0.1
    Uninstalling XStatic-Pygments-1.6.0.1:
      Successfully uninstalled XStatic-Pygments-1.6.0.1
  Found existing installation: moin 2.0.0a0
    Uninstalling moin-2.0.0a0:
      Successfully uninstalled moin-2.0.0a0
  Running setup.py develop for moin
  Found existing installation: py 1.5.4
    Uninstalling py-1.5.4:
      Successfully uninstalled py-1.5.4
  Found existing installation: certifi 2018.8.13
    Uninstalling certifi-2018.8.13:
      Successfully uninstalled certifi-2018.8.13
  Found existing installation: pyparsing 2.2.0
    Uninstalling pyparsing-2.2.0:
      Successfully uninstalled pyparsing-2.2.0
Successfully installed Markdown-3.0 XStatic-1.0.2 XStatic-Pygments-2.2.0.1 XStatic-jQuery-3.3.1.1 certifi-2018.8.24 imagesize-1.1.0 moin py-1.6.0 pyparsing-2.2.1 setuptools-40.4.2 sphinx-1.8.1 typing-3.6.6

]
args += ['--process-dependency-links', ]
if pip_version >= [9, 0]:
args += ['--upgrade-strategy=eager', ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pypa/pipenv#438 9.0 or 10.0?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

girder/girder#2695

manthey commented on Apr 17

pip 9.x honors the flag. pip 8 fails if it is specified.

jbeezley commented on Apr 17

The flag was added in 9, the default was changed in 10.

@ThomasWaldmann
Copy link
Member

ThomasWaldmann commented Sep 22, 2018

also it upgraded Markdown from 2.6.x to 3.0 and this broke a lot of tests.

https://pypi.org/project/Markdown/#history 3.0 is brand new.

https://python-markdown.github.io/change_log/release-3.0/

i'ld suggest first limiting Markdown<3.0.0 via setup.py, make a PR, ci, get it merged and then rebase this PR onto master again.

@RogerHaase RogerHaase merged commit 035df3e into moinwiki:master Sep 23, 2018
@RogerHaase RogerHaase deleted the quickinstall branch October 12, 2018 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants