Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update cabonapi to v0.17.0 #1074

Merged
merged 22 commits into from
Oct 8, 2024
Merged

feat: update cabonapi to v0.17.0 #1074

merged 22 commits into from
Oct 8, 2024

Conversation

Tetrergeru
Copy link
Member

@Tetrergeru Tetrergeru commented Aug 22, 2024 •
edited
Loading

Обновил карбонапи, важные изменения:

  • Добавлена структура evaluator, которая реализует интерфейс эвалюатора из карбонапи
  • Удалены самостоятельные попытки предвариетнльно зарерайтить экспрешен внутри Мойры и вся логика вычислений передана в fetchAndEval из карбонапи
    • Получили поддержку некоторых функций, которые не поддерживались раньше (и ломали Мойру)
    • Будут возникать дополниетльные запросы в базу при использовании мувинг функций с указанием количества точек, а не временного диапазона

@Tetrergeru
Copy link
Member Author

/build

@Tetrergeru Tetrergeru mentioned this pull request Sep 2, 2024
Closed
@Tetrergeru Tetrergeru marked this pull request as ready for review September 10, 2024 14:57
@Tetrergeru Tetrergeru requested a review from a team as a code owner September 10, 2024 14:57
@Tetrergeru
Copy link
Member Author

/build

AleksandrMatsko
AleksandrMatsko requested changes Sep 11, 2024
View reviewed changes
Copy link
Member

@AleksandrMatsko AleksandrMatsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Надушниль

metric_source/local/local.go Outdated Show resolved Hide resolved
metric_source/local/eval.go Show resolved Hide resolved
metric_source/local/eval.go Show resolved Hide resolved
metric_source/local/eval.go Outdated Show resolved Hide resolved
metric_source/local/eval.go Show resolved Hide resolved
metric_source/local/timer.go Show resolved Hide resolved
metric_source/local/timer.go Outdated Show resolved Hide resolved
kissken
kissken reviewed Sep 18, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
AleksandrMatsko
AleksandrMatsko previously approved these changes Oct 4, 2024
View reviewed changes
@Tetrergeru Tetrergeru changed the title feat: update cabonapi to c2229eabd094 feat: update cabonapi to v0.17.0 Oct 4, 2024
@Tetrergeru
Copy link
Member Author

/build

@Tetrergeru
Copy link
Member Author

/build

@Tetrergeru Tetrergeru merged commit 1e92a14 into master Oct 8, 2024
7 checks passed
@Tetrergeru Tetrergeru deleted the feature/update-cabonapi-to-c2229eabd094 branch October 8, 2024 08:18
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024

Build and push Docker images with tag: 2024-10-08.1e92a14

2 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024

Build and push Docker images with tag: 2024-10-08.1e92a14

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024

Build and push Docker images with tag: 2024-10-08.1e92a14

Tetrergeru added a commit that referenced this pull request Oct 8, 2024
@Tetrergeru
Revert "feat: update cabonapi to v0.17.0 (#1074)"
7e3f150 
This reverts commit 1e92a14.
Tetrergeru added a commit that referenced this pull request Oct 8, 2024
@Tetrergeru
Revert "feat: update cabonapi to v0.17.0 (#1074)" (#1111)
4a66a39 
This reverts commit 1e92a14.
@Tetrergeru Tetrergeru mentioned this pull request Oct 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almostinf almostinf almostinf left review comments

@AleksandrMatsko AleksandrMatsko AleksandrMatsko approved these changes

@kissken kissken kissken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tetrergeru @kissken @almostinf @AleksandrMatsko