Created Button component #114
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello there ZaidKhan144 👋
Thank you and congrats 🎉 for opening your first PR on this project.✨
We will review it soon! Till then you can checkout the README.md for more details on it.
Moja global fosters an open and welcoming environment for all our contributors.🌸 Please adhere to our Code Of Conduct.
Feel free to join us on moja global Private Slack by dropping an email here.👩💻
|
@sohamsshah would you like to have a look? |
There was a problem hiding this comment.
@ZaidKhan144 Please add stories for the Button you have added in the Storybook.
There was a problem hiding this comment.
First of all, thanks @ZaidKhan144 for working on this.
Essentially, what we want is the styles to change based on the props. In the present implementation, the size, color etc. props aren't capable of changing css styles. Also, we would prefer having <Button> Click me </Button> over present implementation <Button :btn-text="Click me" />.
If you want more insights upon how to handle dynamic css vars based on vue props, refer this blog. Feel free to ask if blocked anywhere.
|
@sohamsshah No worries man, could you check the props now? |
There was a problem hiding this comment.
Hey @ZaidKhan144 , thanks for working on it. I have suggested changes, after that it is good to be merged!
|
I have added the Button stories in |
Description
This PR addresses #111 . It adds the Button component as per the latest design.
Testing
Buttoncomponent is inflint.ui/src/components/Button/Button.vueButtoncomponent has required props<Button />component you may Import it inflint.ui/src/components/Cards/CardInfoRun.vueand use it like<Button btnText="Run" @onClick="showConfirmRunModal()" />then navigate to http://localhost:8000/flint/dashboardButtondisplays and opens the model on click