Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Migrated to yarn #72

Merged
merged 2 commits into from
Sep 11, 2021
Merged

feat: Migrated to yarn #72

merged 2 commits into from
Sep 11, 2021

Conversation

iamrajiv
Copy link
Member

@iamrajiv iamrajiv commented Sep 9, 2021

Fixes: #47

  • Migrated from npm to yarn
  • Updated Dockerfiles
  • Updated docs
  • Tested locally

Signed-off-by: Rajiv Ranjan Singh <rajivperfect007@gmail.com>
Signed-off-by: Rajiv Ranjan Singh <rajivperfect007@gmail.com>
Copy link
Member

@waridrox waridrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, no breaking changes found 🚀 Can you try running yarn run lint to check for the possible linting errors if any? Thanks

@iamrajiv
Copy link
Member Author

iamrajiv commented Sep 9, 2021

@waridrox I ran yarn run lint no error found. Got one warning related to Storybook but it's not relevant.

warning: Prop 'backgroundColor' requires default value to be set (vue/require-default-prop) at src/stories/Button.vue:29:5:
  27 |       }
  28 |     },
> 29 |     backgroundColor: {
     |     ^
  30 |       type: String
  31 |     }
  32 |   },

@iamrajiv iamrajiv closed this Sep 10, 2021
@iamrajiv iamrajiv reopened this Sep 10, 2021
@iamrajiv iamrajiv closed this Sep 10, 2021
@iamrajiv iamrajiv reopened this Sep 10, 2021
@iamrajiv iamrajiv closed this Sep 11, 2021
@iamrajiv iamrajiv reopened this Sep 11, 2021
@iamrajiv iamrajiv closed this Sep 11, 2021
@iamrajiv iamrajiv reopened this Sep 11, 2021
@iamrajiv iamrajiv merged commit 71b0ebc into moja-global:master Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use yarn instead of npm
4 participants