fix: Changed output simulation table values to read-only and improved docs
#74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rajiv Ranjan Singh <rajivperfect007@gmail.com>
iamrajiv
requested review from
aornugent,
waridrox,
shloka-gupta,
HarshCasper and
shubhamkarande13
|
Hi @iamrajiv - can you please explain what the outcome of setting tables to read only is? Is there a linked issue? |
|
@aornugent The issue is currently in table output we can edit the data i.e. the cells are writeable. So I had updated it to read-only mode. The outcome will same but now the user cannot edit the cell's data. No there is no linked issue in GitHub but I have mentioned this in meeting notes. In the below image we can edit the cell data. This issue has been fixed in this PR.
|
waridrox
changed the title
read-only and improved docs
waridrox
approved these changes
Sep 13, 2021
aornugent
approved these changes
Sep 13, 2021
shubhamkarande13
approved these changes
Sep 13, 2021
Mukulikaa
pushed a commit
to Mukulikaa/FLINT-UI
that referenced
this pull request
Sep 19, 2021
fix: Changed output simulation table values to `read-only` and improved docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description