Update git_and_github_guide.rst #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added little detail to the develop section.
|
@King-kay a good practice is to: Request for a review after you feel that your work is done. Here's how you can request for a review.. It's a repetitive process... You ask for a review, the PR either gets approved or you are asked to make some changes. Once you make the changes just ask for a review again. You could also tag the person/people you've asked for a review from in the comment under the PR. |
|
@chicken-biryani Thanks ,that's why I posted it under the issue comment. followed the request for a review link and I did follow the process and it didnt work for me, so posted it in the comment. |
|
Yes yes! Lgtm! |
shloka-gupta
approved these changes
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added little detail to the develop section.
fix 110 in ../FLINT/issues