-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolves #152 - Adds option to redirect program output of exec:exec to the maven logger. #153
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
package org.codehaus.mojo.exec; | ||
|
||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
/** | ||
* A simple Java 7 pseudo-class based on the Java 8 {@code Consumer} class. Can and should be | ||
* deleted once this project moves to a minimum execution environment of Java 8+. | ||
* | ||
* @param <T> - The type of object that will be acted upon. | ||
* @since 3.0.0 | ||
*/ | ||
interface Invokable<T> { | ||
|
||
/** | ||
* Takes some object and acts upon it. | ||
* | ||
* @param object - The object that will be taken | ||
*/ | ||
void accept(T object); | ||
} |
61 changes: 61 additions & 0 deletions
61
src/main/java/org/codehaus/mojo/exec/LineRedirectOutputStream.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
package org.codehaus.mojo.exec; | ||
|
||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
import java.io.OutputStream; | ||
|
||
/** | ||
* An output stream that captures one line of output at a time, and then | ||
* redirects that line to some {@link Invokable} to act upon as it pleases. This | ||
* class is not thread safe and expects to have only one active writer consuming | ||
* it at any given time. | ||
* | ||
* @since 3.0.0 | ||
*/ | ||
class LineRedirectOutputStream extends OutputStream { | ||
|
||
private StringBuilder currentLine = new StringBuilder(); | ||
private final Invokable<String> linePrinter; | ||
|
||
public LineRedirectOutputStream(Invokable<String> linePrinter) { | ||
this.linePrinter = linePrinter; | ||
} | ||
|
||
@Override | ||
public void write(final int b) { | ||
if ((char) b == '\n') { | ||
printAndReset(); | ||
return; | ||
} | ||
currentLine.append((char) b); | ||
} | ||
|
||
@Override | ||
public void flush() { | ||
if (currentLine.length() > 0) { | ||
printAndReset(); | ||
} | ||
} | ||
|
||
private void printAndReset() { | ||
linePrinter.accept(currentLine.toString()); | ||
currentLine = new StringBuilder(); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more of a prefix instead of a suffix… but it always says
[main]
for me and as such is redundant and unnecessary in the output (makes it unnecessarily wider)…There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Jenkins, they are
[pool-1-thread-1 for channel]
, making the output definitely too wide to read.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mirabilos Good point about prefix instead of suffix, my bad.
As for always getting
[main]
, were you running Maven multi-threaded on a reactor that is bound to have 2 projects running in parallel with this plugin? This option adds no value for single threaded builds, but can become an aid in tracing program output in large reactors with lots of threads. For example 1000+ projects running with 50+ threads.