Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bytecode version of multirelease metadata should be lower or equal to specified version #158

Merged
merged 1 commit into from
Dec 15, 2021

Conversation

Vlatombe
Copy link
Contributor

@Vlatombe Vlatombe commented Dec 15, 2021

This fixes warnings observed in the jenkins project using this rule.

[INFO] --- maven-enforcer-plugin:3.0.0-M3:enforce (display-info) @ MY_PROJECT ---
[INFO] Ignoring requireUpperBoundDeps in com.google.guava:guava
[INFO] Adding ignore: module-info
[WARNING] Invalid bytecodeVersion for com.fasterxml.jackson.module:jackson-module-jaxb-annotations:jar:2.12.1:compile : META-INF/versions/11/module-info.class: expected 55, but was 53

The check was exact, it should actually be ensuring the bytecode level is lower or equal to what is specified.

Fixes FasterXML/jackson-modules-base#126

@olamy olamy added the bug label Dec 15, 2021
@olamy olamy merged commit 90ac027 into mojohaus:master Dec 15, 2021
@Vlatombe Vlatombe deleted the max-multirelease branch December 15, 2021 14:34
Vlatombe added a commit to Vlatombe/plugin-pom that referenced this pull request Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jackson-module-jaxb-annotations 2.11.2 has wrong module info (Java 9 instead of Java 11)
4 participants