Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github report should be sorted on release version #48

Closed
andham opened this issue Mar 14, 2017 · 9 comments
Closed

Github report should be sorted on release version #48

andham opened this issue Mar 14, 2017 · 9 comments
Assignees

Comments

@andham
Copy link
Member

andham commented Mar 14, 2017

Currently (mojo-parent 40) the Github report is sorted on issue number, which makes it hard to see what has been fixed in what release. Change that so it is sorted on release version.

@khmarbaise khmarbaise added this to the 51 milestone May 24, 2020
@khmarbaise
Copy link
Member

khmarbaise commented May 24, 2020

First upgrade to 2.12.1 of maven-changes-plugin second adding configuration like this:

<configuration>
  <githubAPIServerId>github</githubAPIServerId>
  <githubAPIScheme>https</githubAPIScheme>
  <includeOpenIssues>false</includeOpenIssues>
  <onlyMilestoneIssues>true</onlyMilestoneIssues>
  <runOnlyAtExecutionRoot>true</runOnlyAtExecutionRoot> 
  <onlyCurrentVersion>false</onlyCurrentVersion>
</configuration>

If you like to use it locally you have to create a personal access token and configuring that in the settings.xml file instead of the password.

@khmarbaise
Copy link
Member

khmarbaise commented May 24, 2020

The disadvantage of this is: Making a release requires an access token in your github account as well as the configuration in settings.xml.

@khmarbaise
Copy link
Member

Currently I'm thinking about removing the whole github page and make the release notes available via https://github.com/mojohaus/mojo-parent/releases (more more detailed like this https://github.com/khmarbaise/maven-it-extension/releases) or maybe even better via https://github.com/marketplace/actions/release-drafter in a more automated way.

@andham
Copy link
Member Author

andham commented May 25, 2020

IMO we shouldn't forget that Maven plugins are focused around their maven site. If we have the release notes in github we should at least have a link there from the site.

@khmarbaise
Copy link
Member

This is fine for me. +1

@khmarbaise
Copy link
Member

khmarbaise commented May 29, 2020

So after testing some parts the release drafter is not the correct one cause it only uses pull request which is not enough for us.

The following is the result using a github-release-notes-generator (from my own command line; I'm trying to get a way to get that running automatically while a milestone is closed). But I think the content looks ok:

(Attention those release notes are from versions-maven-plugin repo and not from mojo-parent):
@andham WDYT?

Using the following configuration:

  sections:
    - title: "Bug Fixes"
      emoji: "🐞"
      labels: ["bug"]
    - title: "Enhancements"
      emoji: ""
      labels: ["enhancement"]
    - title: "Dependency Upgrades"
      emoji: "🔨"
      labels: ["dependency-upgrade"]
    - title: "Documentation"
      emoji: "📔"
      labels: ["documentation"]

🐞 Bug Fixes

⭐ Enhancements

  • Remove cobertura-maven-plugin #409
  • Removed plexus-i18n #405
  • Fixes Remove taglist from reporting #321 fail the build when parsing XML of child modules fails due to invalid XML #399
  • Upgrade GitHub Actions #398
  • Ensure display output is order, only order at point of printing #394
  • use-latest-versions ignores dependencies with versions defined as properties #340

🔨 Dependency Upgrades

  • Upgrade modello-maven-plugin from 1.9.1 to 1.11 #410
  • Upgrade plugin version for versions-maven-plugin from 2.4 to 2.7 #408
  • Upgrade doxia from 1.7 to 1.9.1 #407
  • Upgrade wagon from 2.12 to 3.4.0 #406
  • Upgrade plexus-interactivity-api from 1.0-alpha-6 to 1.0 #404
  • Upgrade plexus-container-default from 1.7.1 to 2.1.0 #403
  • Upgrade hamcrest-library from 1.3 to hamcrest-core 2.2 #402
  • Upgrade mockito 1.9.5 to 2.28.2 #401
  • Upgrade woodstox-core-asl from 4.2.0 to 4.4.1 #397
  • Upgrade maven-common-artifact-filters to 3.1.0 #389
  • Upgrade plexus-utils to 3.3.0 #388
  • commons-lang3 v3.9 #380

❤️ Contributors

We'd like to thank all the contributors who worked on this release!

@andham
Copy link
Member Author

andham commented Jun 2, 2020

@khmarbaise So the release notes would then be in Github? And we would have a link from the mojo site? The L&F is ok with me.

@khmarbaise
Copy link
Member

Yes the resulting release notes would be put into the release pages on GitHub (#113) and a link in the generated site of the released state as well.

@mfriedenhagen
Copy link
Member

I am all for this. Looking for release-info directly on GitHub is what people are used to nowadays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants