Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub ribbon for plugins using this as parent pom #68

Merged
merged 1 commit into from
Nov 11, 2018

Conversation

darxriggs
Copy link
Contributor

Currently this ribbon always links to the mojo-parent GitHub project.

@darxriggs
Copy link
Contributor Author

darxriggs commented Oct 6, 2018

The newer Taraki wrapper version does not support Java 7 anymore. This is fixed in pull request #69.

When it is merged, I will rebase this one.

darxriggs referenced this pull request in mojohaus/flatten-maven-plugin Oct 7, 2018
 o Fixed ribbon link location.
Currently this ribbon always links to the mojo-parent GitHub project.
@darxriggs darxriggs force-pushed the fix-github-ribbon-plugins branch from 513973e to e61a6f7 Compare November 11, 2018 17:34
@darxriggs
Copy link
Contributor Author

Hi @dantran, this pull request is now ready too.

I suggest to release a new version after the merge, so that other plugins can make use of it.

@darxriggs darxriggs changed the title Fix GitHub ribbon for plugin's using this as parent pom Fix GitHub ribbon for plugins using this as parent pom Nov 11, 2018
@dantran dantran merged commit 56766cb into mojohaus:master Nov 11, 2018
@darxriggs darxriggs deleted the fix-github-ribbon-plugins branch November 11, 2018 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants