-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ArtifactStoreFileSystem timestamp deserialization must be consistent #17
Milestone
Comments
or-shachar
added a commit
to or-shachar/mrm
that referenced
this issue
Sep 13, 2017
closing for new travis run |
opening after #19 was merged |
or-shachar
added a commit
to or-shachar/mrm
that referenced
this issue
Sep 18, 2017
This one is already fixed, right? |
indeed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While maven serialize timestamp to seconds granularity, the
Artifact
object holds timestamp with type "long" (epoch milliseconds).To deserialize timestamp
ArtifactStoreFileSystem
usesGregorianCalendar
(maybe cosnider moving to java8 time?), and sets it to the values it finds in the maven serialization.Problem with this is that if we don't control the milliseconds as well we will get different Long value with each run of this code.
This might not affect most artifact stores but
MemoryArtifactStore
do expect timestamp match. It causes tests that uses MemoryArtifactStore to fail.The text was updated successfully, but these errors were encountered: