Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for mocking timetstamped snapshots #22

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rjatkins
Copy link

  • Ensure any poms loaded from the mrm repo directory that have timestamps for their versions are registered as snapshots, so that we can easily load them later
  • Add factory methods to Artifact to make it easier to build new Artifacts from an existing Artifact object definition
  • Make Artifact responsible for the parsing logic of timestamped versions, to avoid copying it into MockArtifactStore to use during its registration phase
  • Fix typos in FileSystemArtifactStore and ArtifactStoreFileSystem javadoc

 * Ensure any poms loaded from the mrm repo directory that have timestamps for their versions are registered as snapshots, so that we can easily load them later
 * Add factory methods to Artifact to make it easier to build new Artifacts from an existing Artifact object definition
 * Make Artifact responsible for the parsing logic of timestamped versions, to avoid copying it into MockArtifactStore to use during its registration phase
 * Fix typos in FileSystemArtifactStore and ArtifactStoreFileSystem javadoc
 * Collect the timestamp and build number directly from the filename on disk, rather than relying on these to be embedded in the artifact version element. This matches standard maven repo behaviour.
@rfscholte
Copy link
Member

Interesting, although I would have expected that timestamped versions would already be supported. I'm missing some kind of test that demonstrates this feature.
Also consider to improve the content of https://www.mojohaus.org/mrm/mrm-maven-plugin/examples/invoker-tests.html (is probably the best page right now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants