-
Notifications
You must be signed in to change notification settings - Fork 267
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Resolves #889: Fixing ArrayIndexOutOfBound from UseNextVersionsMojo a…
…nd UseNextReleasesMojo in case of no newer versions/releases
- Loading branch information
Showing
6 changed files
with
268 additions
and
50 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
126 changes: 126 additions & 0 deletions
126
versions-maven-plugin/src/test/java/org/codehaus/mojo/versions/UseNextReleasesMojoTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,126 @@ | ||
| package org.codehaus.mojo.versions; | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| import java.util.Collections; | ||
| import java.util.HashMap; | ||
|
|
||
| import org.apache.maven.model.Model; | ||
| import org.apache.maven.project.MavenProject; | ||
| import org.apache.maven.repository.RepositorySystem; | ||
| import org.codehaus.mojo.versions.api.PomHelper; | ||
| import org.codehaus.mojo.versions.change.DefaultVersionChange; | ||
| import org.codehaus.mojo.versions.utils.DependencyBuilder; | ||
| import org.codehaus.mojo.versions.utils.TestChangeRecorder; | ||
| import org.hamcrest.Matchers; | ||
| import org.junit.Before; | ||
| import org.junit.Test; | ||
| import org.mockito.MockedStatic; | ||
|
|
||
| import static java.util.Collections.emptyList; | ||
| import static org.apache.maven.artifact.Artifact.SCOPE_COMPILE; | ||
| import static org.apache.maven.plugin.testing.ArtifactStubFactory.setVariableValueToObject; | ||
| import static org.codehaus.mojo.versions.utils.MockUtils.mockAetherRepositorySystem; | ||
| import static org.codehaus.mojo.versions.utils.MockUtils.mockMavenSession; | ||
| import static org.codehaus.mojo.versions.utils.MockUtils.mockRepositorySystem; | ||
| import static org.hamcrest.MatcherAssert.assertThat; | ||
| import static org.hamcrest.Matchers.hasItem; | ||
| import static org.mockito.ArgumentMatchers.any; | ||
| import static org.mockito.Mockito.mockStatic; | ||
|
|
||
| /** | ||
| * Unit tests for {@link UseNextReleasesMojo} | ||
| */ | ||
| public class UseNextReleasesMojoTest { | ||
|
|
||
| private UseNextReleasesMojo mojo; | ||
| private TestChangeRecorder changeRecorder; | ||
|
|
||
| @Before | ||
| public void setUp() throws Exception { | ||
| RepositorySystem repositorySystemMock = mockRepositorySystem(); | ||
| org.eclipse.aether.RepositorySystem aetherRepositorySystem = | ||
| mockAetherRepositorySystem(new HashMap<String, String[]>() { | ||
| { | ||
| put("dependency-artifact", new String[] {"1.0.0", "1.1.0", "1.1.1-SNAPSHOT"}); | ||
| } | ||
| }); | ||
| changeRecorder = new TestChangeRecorder(); | ||
| mojo = new UseNextReleasesMojo(repositorySystemMock, aetherRepositorySystem, null, changeRecorder.asTestMap()) { | ||
| { | ||
| reactorProjects = emptyList(); | ||
| session = mockMavenSession(); | ||
| project = new MavenProject() { | ||
| { | ||
| setModel(new Model() { | ||
| { | ||
| setGroupId("default-group"); | ||
| setArtifactId("project-artifact"); | ||
| setVersion("1.0.0-SNAPSHOT"); | ||
| } | ||
| }); | ||
| setDependencies(Collections.singletonList(DependencyBuilder.dependencyWith( | ||
| "default-group", "dependency-artifact", "1.1.0", "default", "pom", SCOPE_COMPILE))); | ||
| } | ||
| }; | ||
| } | ||
| }; | ||
| setVariableValueToObject(mojo, "processDependencyManagement", false); | ||
| } | ||
|
|
||
| @Test | ||
| public void testNoNewerReleases() { | ||
| try (MockedStatic<PomHelper> pomHelper = mockStatic(PomHelper.class)) { | ||
| pomHelper | ||
| .when(() -> PomHelper.setDependencyVersion(any(), any(), any(), any(), any(), any())) | ||
| .thenReturn(true); | ||
| pomHelper | ||
| .when(() -> PomHelper.getRawModel(any(MavenProject.class))) | ||
| .thenReturn(mojo.getProject().getModel()); | ||
| mojo.update(null); | ||
| } catch (Exception e) { | ||
| throw new RuntimeException(e); | ||
| } | ||
| assertThat(changeRecorder.getChanges(), Matchers.empty()); | ||
| } | ||
|
|
||
| @Test | ||
| public void testFindANewerRelease() throws IllegalAccessException { | ||
| setVariableValueToObject( | ||
| mojo, "aetherRepositorySystem", mockAetherRepositorySystem(new HashMap<String, String[]>() { | ||
| { | ||
| put("dependency-artifact", new String[] {"1.0.0", "1.1.0", "1.1.1", "2.0.0"}); | ||
| } | ||
| })); | ||
| try (MockedStatic<PomHelper> pomHelper = mockStatic(PomHelper.class)) { | ||
| pomHelper | ||
| .when(() -> PomHelper.setDependencyVersion(any(), any(), any(), any(), any(), any())) | ||
| .thenReturn(true); | ||
| pomHelper | ||
| .when(() -> PomHelper.getRawModel(any(MavenProject.class))) | ||
| .thenReturn(mojo.getProject().getModel()); | ||
| mojo.update(null); | ||
| } catch (Exception e) { | ||
| throw new RuntimeException(e); | ||
| } | ||
| assertThat( | ||
| changeRecorder.getChanges(), | ||
| hasItem(new DefaultVersionChange("default-group", "dependency-artifact", "1.1.0", "1.1.1"))); | ||
| } | ||
| } |
Oops, something went wrong.