Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flipping it-property-updates-report-002-slow #729

Closed
jarmoniuk opened this issue Sep 30, 2022 · 5 comments
Closed

Flipping it-property-updates-report-002-slow #729

jarmoniuk opened this issue Sep 30, 2022 · 5 comments

Comments

@jarmoniuk
Copy link
Contributor

This exercise is about investigating the flipper mentioned in the summary. As far as I've seen, it only occurs on MacOS.
@jarmoniuk
Copy link
Contributor Author

it-property-updates-report-002-slow.zip

@jarmoniuk
Copy link
Contributor Author

The test doesn't take into account that the overall execution time may be longer due to artifact retrieval. Strangely enough, this happens almost exclusively on MacOS platforms. Anyway, I think this should be done differently, e.g. by profiling and not using an it test.

jarmoniuk added a commit to jarmoniuk/versions-maven-plugin that referenced this issue Oct 3, 2022
@jarmoniuk
mojohaus#729: Ignoring the flipper. This test should be used for prof…
20544fd 
…iling and not as part of integration testing
jarmoniuk added a commit to jarmoniuk/versions-maven-plugin that referenced this issue Oct 4, 2022
@jarmoniuk
mojohaus#729: Ignoring the flipper. This test should be used for prof…
156ee09 
…iling and not as part of integration testing
jarmoniuk added a commit to jarmoniuk/versions-maven-plugin that referenced this issue Oct 4, 2022
@jarmoniuk
mojohaus#729: Ignoring the flipper. This test should be used for prof…
8163f4d 
…iling and not as part of integration testing
slawekjaranowski pushed a commit that referenced this issue Oct 4, 2022
@jarmoniuk @slawekjaranowski
#729: Ignoring the flipper. This test should be used for profiling an…
720ff9e 
…d not as part of integration testing
@slawekjaranowski
Copy link
Member

Please rebase other PR, should be better

jarmoniuk added a commit to jarmoniuk/versions-maven-plugin that referenced this issue Oct 4, 2022
@jarmoniuk
mojohaus#729: Ignoring the flipper. This test should be used for prof…
db8cc99 
…iling and not as part of integration testing
@jarmoniuk
Copy link
Contributor Author

Rebased

jarmoniuk added a commit to jarmoniuk/versions-maven-plugin that referenced this issue Oct 4, 2022
@jarmoniuk
mojohaus#729: Ignoring the flipper. This test should be used for prof…
fd19f77 
…iling and not as part of integration testing
jarmoniuk added a commit to jarmoniuk/versions-maven-plugin that referenced this issue Oct 6, 2022
@jarmoniuk
mojohaus#729: Ignoring the flipper. This test should be used for prof…
35dbaa3 
…iling and not as part of integration testing
@jarmoniuk
Copy link
Contributor Author

@slachiewicz please close

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jarmoniuk @slawekjaranowski @slachiewicz