Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

versions:lock-snapshots after upgrading from 2.13.0 to 2.14.0 #899

Closed
g-chcht opened this issue Jan 6, 2023 · 6 comments · Fixed by #901
Closed

versions:lock-snapshots after upgrading from 2.13.0 to 2.14.0 #899

g-chcht opened this issue Jan 6, 2023 · 6 comments · Fixed by #901
Labels
bug
Milestone
2.15.0

Comments

@g-chcht
Copy link

g-chcht commented Jan 6, 2023 •
edited
Loading

Hello guys,

Full name:
org.codehaus.mojo:versions-maven-plugin:2.14.0:lock-snapshots

What steps will reproduce the bug?
mvn -U --batch-mode org.codehaus.mojo:versions-maven-plugin:2.14.0:lock-snapshots

What is the expected behavior?

searches the pom for all -SNAPSHOT versions and replaces them with the current timestamp version of that -SNAPSHOT, e.g. -20090327.172306-4

What do you see instead?
-SNAPSHOT not replaced in pom.xml

Additional information

Regards,
@jarmoniuk
Copy link
Contributor

@g-chcht could you provide a pom.xml which contains a snapshot to lock so that we could try to reproduce the issue?

@jarmoniuk
Copy link
Contributor

Never mind, managed to reproduce it with a bespoke pom. And confirmed. Thanks for the report.

@jarmoniuk
Copy link
Contributor

@g-chcht to be on the safe side, could you please provide an artifact which you wanted to lock so that we could verify the fix using real world artifacts?

@jarmoniuk
Copy link
Contributor

jarmoniuk commented Jan 6, 2023 •
edited
Loading

@slawekjaranowski unfortunately, hard to fix with the use of mrm-maven-plugin: no metadata found even with 2.13.0 (before the switch to Resolver). Do you happen to know any timestamped maven artifacts to test it against?

Edit: found one.

jarmoniuk added a commit to jarmoniuk/versions-maven-plugin that referenced this issue Jan 7, 2023
@jarmoniuk
Resolves mojohaus#899: Corrected the invocation of Resolver to retrie…
cc0da42 
…ve the timestamped snapshot version; added unit tests for LockSnapshotsMojo for the case when no timestamped versions are found
jarmoniuk added a commit to jarmoniuk/versions-maven-plugin that referenced this issue Jan 7, 2023
@jarmoniuk
Resolves mojohaus#899: Corrected the invocation of Resolver to retrie…
782dbd0 
…ve the timestamped snapshot version; added unit tests for LockSnapshotsMojo for the case when no timestamped versions are found
jarmoniuk added a commit to jarmoniuk/versions-maven-plugin that referenced this issue Jan 7, 2023
@jarmoniuk
Resolves mojohaus#899: Corrected the invocation of Resolver to retrie…
ff79a17 
…ve the timestamped snapshot version; added unit tests for LockSnapshotsMojo for the case when no timestamped versions are found
jarmoniuk added a commit to jarmoniuk/versions-maven-plugin that referenced this issue Jan 8, 2023
@jarmoniuk
Resolves mojohaus#899: Corrected the invocation of Resolver to retrie…
a6baf81 
…ve the timestamped snapshot version; added unit tests for LockSnapshotsMojo for the case when no timestamped versions are found
jarmoniuk added a commit to jarmoniuk/versions-maven-plugin that referenced this issue Jan 8, 2023
@jarmoniuk
Resolves mojohaus#899: Corrected the invocation of Resolver to retrie…
17c17fa 
…ve the timestamped snapshot version; added unit tests for LockSnapshotsMojo for the case when no timestamped versions are found
jarmoniuk added a commit to jarmoniuk/versions-maven-plugin that referenced this issue Jan 8, 2023
@jarmoniuk
Resolves mojohaus#899: Corrected the invocation of Resolver to retrie…
9a4c0ee 
…ve the timestamped snapshot version; added unit tests for LockSnapshotsMojo for the case when no timestamped versions are found
jarmoniuk added a commit to jarmoniuk/versions-maven-plugin that referenced this issue Jan 8, 2023
@jarmoniuk
Resolves mojohaus#899: Corrected the invocation of Resolver to retrie…
8fc252b 
…ve the timestamped snapshot version; added unit tests for LockSnapshotsMojo for the case when no timestamped versions are found
@slawekjaranowski slawekjaranowski linked a pull request Jan 9, 2023 that will close this issue
Resolves #899: Corrected the invocation of Resolver to retrieve the timestamped snapshot version #901
Merged
@slawekjaranowski slawekjaranowski added this to the 2.15.0 milestone Jan 9, 2023
@g-chcht
Copy link
Author

g-chcht commented Jan 9, 2023

Hey,
Thanks for the quick actions !
Need anything else then ?

@jarmoniuk
Copy link
Contributor

Nope. Again, thanks for the report.

slawekjaranowski pushed a commit that referenced this issue Jan 9, 2023
@jarmoniuk @slawekjaranowski
Resolves #899: Corrected the invocation of Resolver to retrieve the t…
bd40038 
…imestamped snapshot version; added unit tests for LockSnapshotsMojo for the case when no timestamped versions are found
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.15.0
3 participants
@jarmoniuk @slawekjaranowski @g-chcht