Resolves #1042: Fixed set logic wrt processAllModules #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
versions-maven-plugin/src/main/java/org/codehaus/mojo/versions/SetMojo.java
Outdated
Show resolved
Hide resolved
maybe not add new parameter ... |
jarmoniuk
changed the title
jarmoniuk
force-pushed
the
issue-1042-set
branch
from
cd0ea3a
to
dd92032
Compare
slawekjaranowski
approved these changes
Feb 21, 2024
pativa
pushed a commit
to AvanzaBank/versions-maven-plugin
that referenced
this pull request
Apr 15, 2024
slawekjaranowski
added a commit
that referenced
this pull request
Jul 13, 2024
slawekjaranowski
added a commit
that referenced
this pull request
Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1042 is a pretty particular case which exposes a bug in the set logic.
The new version is initially set "to be tried out". Then, it is being set for the second time when processing changes. However, there's also some logic which is supposed to see if there are modules using the module that is being changed. This logic was responsible for the reversed change in the case of this particular issue.
When investigating, I've noticed that
processAllModuleshas two meanings: one is to process two modules regardless whether they match the current module; the second makes the matching logic traverse the whole reactor instead of the current module's subtree in search of modules which use the current module as parent. Because of that, I have introduced a new option,fullTreeMatch, which should by default befalseas I don't suppose it to be used very often.@slawekjaranowski please review.