Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

363:Force update parent version with real version #364

Merged
merged 8 commits into from
Jul 8, 2021

Conversation

akilantech
Copy link
Contributor

If parent version is RELEASE or LATEST, update-parent does not update it to real version. hence, adding this feature to replace RELEASE or LATEST with real version.

@akilantech
Copy link
Contributor Author

Please some one help me merged in next version

@khmarbaise
Copy link
Member

Could you rebase against current master....

@khmarbaise khmarbaise linked an issue May 16, 2020 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Jun 5, 2021

This PR is stale because it has been open 365 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Jun 5, 2021
@akilantech
Copy link
Contributor Author

start working on this. missed your past message

@github-actions github-actions bot removed the Stale label Jun 6, 2021
@akilantech
Copy link
Contributor Author

maintainer, please approve the workflow.

@bmarwell
Copy link
Contributor

Will take a look next week, thanks.

@akilantech
Copy link
Contributor Author

Any luck @bmarwell ?

* @since 2.8
*/
@Parameter( property = "forceUpdate", defaultValue = "False" )
protected Boolean forceUpdate = null;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe should be boolean rather than Boolean to avoid NPE.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, Please approve.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olamy Please help

akilantech and others added 3 commits June 30, 2021 18:36
Co-authored-by: Olivier Lamy <olamy@apache.org>
…erMojo.java

Co-authored-by: Olivier Lamy <olamy@apache.org>
2) Corrected version from.
@olamy olamy merged commit 4fd669c into mojohaus:master Jul 8, 2021
@akilantech akilantech deleted the feature/363-force-update-parent branch July 9, 2021 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update-parent for LATEST and RELEASE versions
4 participants