Cache result of getBestFitRule (fixes #575) #365
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
"Minimal" reproducer project: On my system, this takes > 1 minute without my fix and ~ 5 seconds with my fix. If I find some more time I might wrap it into an maven-invoker test (with the timeout feature of MINVOKER-233) |
|
This PR is stale because it has been open 365 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
|
Ah, the attack of the stale bot :/ - FWIW, this is still an issue, we use this patch internally to speed up execution of the report generation... |
This was identified as a performance hotspot and the result is static for each run, adding a cache dramatically speeds up some executions.
|
Added invoker test to demonstrate the problem |
TobiX
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was identified as a performance hotspot and the result is static
for each run, adding a cache dramatically speeds up some executions.
This is probably not the correct solution, but provides a dramatic speed-up in my cases. While
getBestFitRuleis called only once for each dependency independency-updates-reportandplugin-updates-report, it is called over and over inproperty-updates-report(over 38,000,000 times in one of my sample projects). Unfortunately, I got lost in the call-graph pretty quickly - so if someone could prod me into the right direction for a better fix, that would be appreciated.