Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #391 - added support for header authorization #392

Closed
wants to merge 1 commit into from

Conversation

eroznik
Copy link

@eroznik eroznik commented Apr 20, 2020

Added support for the Maven 3.x repository system, since I didn't want to break the current implementation(backward compatibility for current plugin users) I added a new configuration property to control which version resolution option should be used(useRepositorySystem, default=false).

The changes were tested locally using Maven 3.6.0 on Ubuntu while accessing:

  • Maven Central
  • self hosted Sonatype Nexus
  • self hosted Gitlab (this case is the reason for the pull request/issue)

The observed behavior before the change:

  • an artifact package + metadata was deleted from the local repository
  • executed versions:update-properties, remote requests to the self hosted Gitlab instance failed(404, Gitlab response for unauthorized requests)
  • the parent version wasn't changed

The observed behavior after the change, with useRepositorySystem=true:

  • an artifact package + metadata was deleted from the local repository
  • executed versions:update-properties, remote requests to the self hosted Gitlab went through, artifact metadata fetched successfully
  • the parent version was updated

…m - added a new configuration property to control which version resolution option should be used(useRepositorySystem)
@eroznik eroznik changed the title Fixed #391 - added support for the Maven 3.x repository system Fixed #391 - added support for header authorization Aug 29, 2020
@eroznik
Copy link
Author

eroznik commented Aug 29, 2020

@khmarbaise issue summary was updated to added support for header authorization which describes exactly what i wanted to accomplish with this pull request. Beside the conflicts that are current present, is there anything else required from my side to proceed with the pull request?

@github-actions
Copy link

This PR is stale because it has been open 365 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@eroznik
Copy link
Author

eroznik commented Aug 30, 2021

Could a maintainer please look at this? Should the conflicts get resolved so the PR gets approved? Is there something that needs to be changed? Or do we close it and forget about it?

@atokle
Copy link

atokle commented Oct 26, 2021

We need this fix.
@olamy I see that you have recent activity here. Can you help @eroznik with what is needed to get this fix merged?

@slawekjaranowski
Copy link
Member

Looks like fixed in: #825

@eroznik thanks for your effort

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants