Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split into multiple module project #619

Closed
wants to merge 3 commits into from
Closed

split into multiple module project #619

wants to merge 3 commits into from

Conversation

XenoAmess
Copy link
Contributor

No description provided.

@XenoAmess XenoAmess force-pushed the split_into_multiple_module_project branch from 7f0db71 to dfd494b Compare July 15, 2022 14:25
@XenoAmess
Copy link
Contributor Author

only split by module without other changes.
@slawekjaranowski

slawekjaranowski
slawekjaranowski reviewed Jul 19, 2022
View reviewed changes
version-maven-plugin-api/pom.xml Outdated Show resolved Hide resolved
version-maven-plugin-api/pom.xml Outdated Show resolved Hide resolved
version-maven-plugin-api/pom.xml Outdated Show resolved Hide resolved
version-maven-plugin-api/pom.xml Outdated Show resolved Hide resolved
@XenoAmess XenoAmess force-pushed the split_into_multiple_module_project branch from dfd494b to ba910ea Compare July 19, 2022 16:25
@XenoAmess
Copy link
Contributor Author

@slawekjaranowski done.
please review again.

@bmarwell bmarwell mentioned this pull request Jul 20, 2022
Merged
@slawekjaranowski
Copy link
Member

slawekjaranowski commented Jul 21, 2022 •
edited
Loading

we should address issues:

  • we should not change path for generated xsd files
  • api - should contains only interfaces, enums , ...
  • api - should have minimal dependencies - even no additional dependencies
  • we need check project site after such change

@slawekjaranowski
Copy link
Member

https://groups.google.com/g/mojohaus-dev/c/hRltMfTmB4o/m/CuRRV7fdAAAJ

@slawekjaranowski slawekjaranowski mentioned this pull request Oct 15, 2022
Closed
@slawekjaranowski
Copy link
Member

Done in #758 @XenoAmess thanks for your effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slawekjaranowski slawekjaranowski slawekjaranowski left review comments

@bmarwell bmarwell Awaiting requested review from bmarwell

@hboutemy hboutemy Awaiting requested review from hboutemy

@khmarbaise khmarbaise Awaiting requested review from khmarbaise

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XenoAmess @slawekjaranowski