Fix for issue #323: using version range if currentVersion is not available for DependencyUpdatesXmlRenderer #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrzejj0
force-pushed
the
issue-323-npe
branch
from
6fe741d
to
75b2712
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DependencyUpdatesXmlRenderer::getVersionsBlocks is used for both dependency and plugins xml report blocks. While the html renderer uses the version as specified in the Dependency class (which is a range if there's no current version specified), the XML renderer only uses an ArtifactVersions object.
In this PR I'm mimicking the behaviour of the HTML renderer in that regard, i.e. using the range if a concrete version is not given.