Fixing #604: npe in DependencyVersionChanger if artifact version is null #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrzejj0
force-pushed
the
issue-604-npe-dependency-version-changer
branch
from
4a6c2d3
to
ae7d32b
Compare
|
Please also see #656 This PR can be reworked to incorporate it and use a unit test instead. |
|
|
||
| <artifactId>child</artifactId> | ||
|
|
||
| </project> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing an NPE in DependecyVersionChanger if the old version is null + checkstyle fixes + some minor refactoring.
Edit: There's no verification in that test case as the test is considered successful if no exception is raised :-)